Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix layout issue in vc u3 #677

Merged
merged 1 commit into from
Aug 28, 2019
Merged

fix layout issue in vc u3 #677

merged 1 commit into from
Aug 28, 2019

Conversation

zhoumeina
Copy link
Contributor

Signed-off-by: Meina Zhou meinaz@vmware.com
Fix the layout in create vch in vsphere 6.7 u3. Because the modal dialog has some changes. The original element no longer exist. Need to modify to compatible way.

Fixes #

PR acceptance checklist:

[ ] All unit tests pass
[ ] All e2e tests pass
[ ] Unit test(s) included*
[ ] e2e test(s) included*
[ ] Screenshot attached and UX approved*

*if applicable, add n/a if not

Signed-off-by: Meina Zhou <meinaz@vmware.com>
@codecov-io
Copy link

Codecov Report

Merging #677 into master will increase coverage by 0.04%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage   65.98%   66.02%   +0.04%     
==========================================
  Files          61       61              
  Lines        2919     2917       -2     
  Branches      519      520       +1     
==========================================
  Hits         1926     1926              
+ Misses        691      689       -2     
  Partials      302      302
Impacted Files Coverage Δ
...p/create-vch-wizard/create-vch-wizard.component.ts 23.52% <33.33%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04964fd...649c6d8. Read the comment docs.

@zhoumeina zhoumeina self-assigned this Aug 28, 2019
@zhoumeina zhoumeina merged commit 839c7b4 into vmware:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants